Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new README.md for new Docusaurus projects #930

Merged
merged 2 commits into from
Sep 1, 2018
Merged

Added new README.md for new Docusaurus projects #930

merged 2 commits into from
Sep 1, 2018

Conversation

jaril
Copy link
Contributor

@jaril jaril commented Aug 30, 2018

Motivation

Fixes #925

First pass at a basic README.md for new websites.

I checked the PRs for documentation websites built with Docusaurus, and it seemed that most PRs were related to adding/editing content, and less about configuring layouts/siteConfig. That's why I added instructions for the popular use cases in the README.md, each with a link to the relevant part of the docs website for further reading.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check that running docusaurus-init copies the new README.md to the website folder

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 30, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 30, 2018

Deploy preview for docusaurus-preview ready!

Built with commit c78ae64

https://deploy-preview-930--docusaurus-preview.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think that it is too long and can be intimidating. For more details they should open Docusaurus website directly. I think a very basic quick start is sufficient. The goal is so that the contributor to new Docusaurus project can quickly get started.

What do you think ?

Example:


🚀   Introduction

This website was created with Docusaurus.

📟   Install and Usage

First of all, you will need to install all the dependencies for the website

$ yarn

Now just run your dev server

$ yarn start

That's it! Now you can make changes to the docs folder of the project directory.

Check docusaurus.io to see more about Docusaurus!


@JoelMarcey @yangshun any opinions ?

@jaril
Copy link
Contributor Author

jaril commented Aug 30, 2018

Understood - I erred on having too much than too little (checked out #246 requirements), since it's easy to trim afterwards. Makes sense that the goal should be to have contributors get started without being intimidated, and directly point them towards the website for additional details.

Bonus points for keeping the documentation references in one place, rather than having to update this README.md anytime there are changes.

Will wait for feedback from @JoelMarcey and @yangshun.

@JoelMarcey
Copy link
Contributor

@notjaril Thanks for doing this! 👍 I agree that we should have a simple readme and point people to existing links.

@yangshun yangshun changed the title added new README.md for new Docusaurus projects Added new README.md for new Docusaurus projects Sep 1, 2018
@yangshun
Copy link
Contributor

yangshun commented Sep 1, 2018

This looks awesome @notjaril! Let's merge this.

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @notjaril!

@yangshun
Copy link
Contributor

yangshun commented Sep 1, 2018

CI tests are failing but it seems like a flaky issue and we can merge this.

@yangshun yangshun merged commit 7987e66 into facebook:master Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants